So I decided to get rid of the category module that would appear on the right, and decided to add my categories to appear in the top menu bar.
The bug I am seeing is that I added all my categories fine, but added a category twice by accident. So when I delete the duplicate which is in the middle of all the other categories, once deleted, all the other categories entered below the deleted one vanish also. I assumed something drastic happened. So I added all the categories below that again. When refreshing the store page, I saw many duplicates so I had to go back and check the menu area of the admin again.
How I set it up was I created a "Category" category, and added all my categories below it as sub-categories.
The issue I see is that if you delete a sub-category, all the sub-categories below it vanish. But if you click on the "Menus" button again in the admin area, which refreshes the page, they all reappear.
Not sure why this happens, but might need further looking at.
The bug I am seeing is that I added all my categories fine, but added a category twice by accident. So when I delete the duplicate which is in the middle of all the other categories, once deleted, all the other categories entered below the deleted one vanish also. I assumed something drastic happened. So I added all the categories below that again. When refreshing the store page, I saw many duplicates so I had to go back and check the menu area of the admin again.
How I set it up was I created a "Category" category, and added all my categories below it as sub-categories.
The issue I see is that if you delete a sub-category, all the sub-categories below it vanish. But if you click on the "Menus" button again in the admin area, which refreshes the page, they all reappear.
Not sure why this happens, but might need further looking at.
In General
Share this post:
Accepted Answer
Confirmed and added to the tracker Breck: https://github.com/arastta/arastta/issues/642
Thanks for reporting.
Regards
Thanks for reporting.
Regards
Responses (8)
-
Accepted Answer
-
Accepted Answer
-
Accepted Answer
Hi cneyt
I have a couple of other bugs I reported as part of a 'help' post. I dont think anyone has picked them up yet.
Both bugs are in code which doesnt handle multi sites properly.
1.
bug = system\library\app\catalog.php is loading the wrong shop id on all pages except home -- I changed to the code below - two lines commented
// Store
if (isset($_SERVER['HTTPS']) && (($_SERVER['HTTPS'] == 'on') || ($_SERVER['HTTPS'] == '1'))) {
// $store_query = $this->db->query("SELECT * FROM " . DB_PREFIX . "store WHERE REPLACE(`ssl`, 'www.', '') = '" . $this->db->escape('https://' . str_replace('www.', '', $_SERVER['HTTP_HOST']) . rtrim(dirname($_SERVER['PHP_SELF']), '/.\\') . '/') . "'");
$sql = "SELECT * FROM " . DB_PREFIX . "store WHERE REPLACE(`ssl`, 'www.', '') = '" . $this->db->escape('https://' . str_replace('www.', '', $_SERVER['HTTP_HOST']) . '/') . "'";
} else {
// $store_query = $this->db->query("SELECT * FROM " . DB_PREFIX . "store WHERE REPLACE(`url`, 'www.', '') = '" . $this->db->escape('http://' . str_replace('www.', '', $_SERVER['HTTP_HOST']) . rtrim(dirname($_SERVER['PHP_SELF']), '/.\\') . '/') . "'");
$sql = "SELECT * FROM " . DB_PREFIX . "store WHERE REPLACE(`url`, 'www.', '') = '" . $this->db->escape('http://' . str_replace('www.', '', $_SERVER['HTTP_HOST']) . '/') . "'";
}
$store_query = $this->db->query($sql);
2.
Admin menus bug = Add menu bug is caused by code not including the 'stores' array index when the menu item is added
Fix is admin\model\appearance\menu.php at line 109
$menu = array(
'name' =>$data['menu_desc'][0]['name'],
'menu_type' =>$data['type'],
'menu_id' => $menu_id
);
needs store array adding to match previous line which auto added store 1 to the db and later code which expects a store array
$menu = array(
'name' =>$data['menu_desc'][0]['name'],
'menu_type' =>$data['type'],
'menu_id' => $menu_id,
'store' => [0]
);
It would be lovely if I didnt have to keep re-editing these into each Arastta update I do.
Cheers -
Accepted Answer
Then instead of posting them here, submit the bugs and edits on github so they can be reviewed and added to the base code. -
Accepted Answer
Thanks David for your contributions. We can review and merge to the core if you submit a Pull Request on GitHub. Also, you can use the Modification system instead of changing the core files:
https://arastta.org/docs/developers/modification-system
Regards -
Accepted Answer
-
Accepted Answer
I wan't giving you an attitude. You were complaining about having to apply the edits again after updates.
I was suggesting you submit them on github so they can be added to the core files for everyone and you wouldn't have to edit anymore after updating. -
Accepted Answer
Hi @David,
Thank you for the report and for your fix. As friends told, it would be better to send a Pull Request over Github for your valuable fix. Thus, all the community benefit from it.
I think there is a misunderstood between you and Breck. Take it easy and keep in mind the community
Regards
Your Reply
Please login to post a reply
You will need to be logged in to be able to post a reply. Login using the form on the right or register an account if you are new here.
Register Here »