I tried today to setup google base feed for our products, and it kicks back a bunch of errors.
One seems to be the structure is incorrect which seems to cause many of the other errors.

http://store.valleybeekeeping.com/index.php/feed/google_base

Error says improper xml format.

Guess it's something else to add to the to do list.
In General
Saturday, March 04 2017, 10:45 PM
Share this post:

Accepted Answer

Wednesday, March 15 2017, 06:51 PM - #Permalink
A new zip with a few minor fixes.

Demo: https://demo.arastta.no/feed/google_base.html
Attachments:
The reply is currently minimized Show
Responses (19)
  • Accepted Answer

    Saturday, March 11 2017, 08:53 PM - #Permalink
    Only seems to pull 3 or 4 items into the feed.
    The reply is currently minimized Show
  • Accepted Answer

    Saturday, March 11 2017, 11:59 PM - #Permalink
    I've attached what I get with my Opera browser.
    Attachments:
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 12 2017, 12:14 AM - #Permalink
    That looks interesting.
    I checked using different browsers.

    Here's using Chrome and Firefox.
    Chrome has no format, firefox has format but only 2 items

    And google itself tells me itself when trying to upload products that it's not an xml formatting error.
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 12 2017, 12:34 AM - #Permalink
    Just tested it with Explorer.


    Internet Explorer cannot display this feed

    This feed contains code errors.
    The reply is currently minimized Show
  • Accepted Answer

    Sunday, March 12 2017, 12:41 AM - #Permalink
    I just downloaded Opera to test it out, and it shows the feed ok, but it only shows a fraction of the products.
    The reply is currently minimized Show
  • Accepted Answer

    Tuesday, March 14 2017, 02:16 PM - #Permalink
    The problem is most likely caused by some special character in your data, not being properly output for the xml: https://github.com/arastta/arastta/blob/master/catalog/controller/feed/google_base.php#l33

    I'm sure Google gave you some more details when you tried to add it.

    Btw! Maybe you're also missing some required data on some products.

    https://support.google.com/merchants/answer/188477?hl=en&ref_topic=3164294 -> https://support.google.com/merchants/answer/7052112
    The reply is currently minimized Show
  • Accepted Answer

    Tuesday, March 14 2017, 02:57 PM - #Permalink
    I checked their site again and found more info.

    Feed name	Feed Id	Customer Id	Upload time		
    Valley Beekeeping Supplies 103256711 6548565 Mar 12, 2017 12:00 am EST

    Item Id Line number Message Type Values Item title
    5 XML formatting error Error "Column Nr.=830"


    It just doesn't tell me really what or where to look for the issue.
    Says line 5 column 830. Looking at the feed in Chrome, line 5 looks ok.
    Not sure there are even 830 columns.
    The reply is currently minimized Show
  • Accepted Answer

    Tuesday, March 14 2017, 03:08 PM - #Permalink
    Column nr. 830 is the position on that line, the count of characters and spaces.
    The reply is currently minimized Show
  • Accepted Answer

    Wednesday, March 15 2017, 02:16 AM - #Permalink
    So I took line 5 from http://store.valleybeekeeping.com/index.php/feed/google_base
    Pasted it into notepad++ and looked for character place 830.

    style="font-family: Verdana, Arial, Helvetica, sans-

    It comes up between 'Ar' in Arial from above.
    So unless I am doing something wrong, I don't see an incorrect character.

    This is the item it's getting the info from if it helps.
    http://store.valleybeekeeping.com/index.php/pails/1-9l-2kg-plastic-pail
    The reply is currently minimized Show
  • Accepted Answer

    Wednesday, March 15 2017, 12:28 PM - #Permalink
    Remember, if you changed anything between Google reading and now, the feeds data is different ...

    Btw! Try removing your mail address and other special stuff from your descriptions, like Google mention in the links I gave you above. You don't want to feed the spam boots with your mail anyway, I'm pretty sure your customers is able to locate the contact us form.
    The reply is currently minimized Show
  • Accepted Answer

    Wednesday, March 15 2017, 03:09 PM - #Permalink
    I must be doing something wrong.
    I took out the email address and tried to run it again.

    Error now shows:
    Line Nr. Column Nr.
    4 816

    If I take line 4 from http://store.valleybeekeeping.com/index.php/feed/google_base

    It doesn't have 816 characters.

    How do I get the correct info from the feed to get the proper lines and characters?
    The reply is currently minimized Show
  • Accepted Answer

    Wednesday, March 15 2017, 05:35 PM - #Permalink
    Once again: https://support.google.com/merchants/answer/188476?hl=en&ref_topic=3163841

    Tip! Test adding CDATA sections to the description attributes etc. in the script.
    The reply is currently minimized Show
  • Accepted Answer

    Wednesday, March 15 2017, 05:54 PM - #Permalink
    Anyhow the formating of this feed sucks, and it's even a bug with the link tag ... ;)

    Try replacing your /catalog/controller/feed/google_base.php with the one attached.
    Attachments:
    The reply is currently minimized Show
  • Accepted Answer

    Thursday, March 16 2017, 01:39 AM - #Permalink
    Great fix. Looks much better and Google accepted all of the products.

    Only 3 errors and that's because I have 3 products for $0.00.
    Guess I'll have to delete them and we are all good.

    Thanks a bunch for that.
    The reply is currently minimized Show
  • Accepted Answer

    Thursday, March 16 2017, 11:18 AM - #Permalink
    Awesome :)

    I'll make a PR to the core then.
    The reply is currently minimized Show
  • Accepted Answer

    Friday, March 24 2017, 01:06 AM - #Permalink
    Another suggestion: Apparently you have to have SSL installed to use this.
    I know some credit card mods check if you are using SSL, and block from enabling the mod if it's not installed.
    Maybe something like this could be added. It will prevent peoples accounts from being suspended when trying to use it without.
    Or at least have a warning in the mods admin area about suspensions with SSL.
    The reply is currently minimized Show
  • Accepted Answer

    Friday, March 24 2017, 01:20 AM - #Permalink
    Today, all stores should have SSL.
    My proposal, block access to admin and store if you don't have it ... ;)
    The reply is currently minimized Show
  • Accepted Answer

    Friday, March 24 2017, 01:36 AM - #Permalink
    I am looking into it right now. Trying to understand what I need.
    From what I can tell, because my store is in a sub-domain, I can get a way with an SSL for the sub-domain only.
    Just hoping store in a sub-domain doesn't create more headaches to come.
    The reply is currently minimized Show
  • Accepted Answer

    Saturday, March 25 2017, 03:30 AM - #Permalink
    You ever see this? https://letsencrypt.org/
    Free encryption for SSL.
    The reply is currently minimized Show
Your Reply